generalize profile links

app/controllers/users_controller.rb

@@ -355,9 +355,10 @@ def edit_profile
     render layout: 'without_sidebar'
   end
 
+  # to be deleted (when I'm done debugging with it)
   def validate_profile_website(profile_params)
     uri = profile_params[:website]
-
+    
     if URI.parse(uri).instance_of?(URI::Generic)
       # URI::Generic indicates the user didn't include a protocol, so we'll add one now so that it can be
       # parsed correctly in the view later on.
@@ -368,14 +369,30 @@ def validate_profile_website(profile_params)
     flash[:danger] = 'Invalid profile website link.'
   end
 
-  def update_profile
-    profile_params = params.require(:user).permit(:username, :profile_markdown, :website, :twitter, :discord)
-    profile_params[:twitter] = profile_params[:twitter].delete('@')
+  def validate_profile_websites(profile_params)
+    sites = profile_params[:user_websites]
+    sites.all? { |u| u = ensure_protocol(u.url) }
+  end
 
-    if profile_params[:website].present?
-      validate_profile_website(profile_params)
+  def ensure_protocol(uri)
+    if URI.parse(uri).instance_of?(URI::Generic)
+      # URI::Generic indicates the user didn't include a protocol, so we'll add one now so that it can be
+      # parsed correctly in the view later on.
+      return "https://#{uri}"
+    else
+      return uri
     end
+  rescue URI::InvalidURIError
+    return nil
+  end    
 
+  def update_profile
+    profile_params = params.require(:user).permit(:username, :profile_markdown, :website, :discord, :user_websites)
+
+    if profile_params[:user_websites].present?
+      profile_params[:user_websistes] = validate_profile_websites(profile_params) || flash[:danger] = "Invalid external link"
+    end
+
     @user = current_user
 
     if params[:user][:avatar].present?

app/models/user.rb

@@ -1,3 +1,4 @@
+# coding: utf-8
 # Represents a user. Most of the User's logic is controlled by Devise and its overrides. A user, as far as the
 # application code (i.e. excluding Devise) is concerned, has many questions, answers, and votes.
 class User < ApplicationRecord
@@ -27,6 +28,8 @@ class User < ApplicationRecord
   has_many :comment_threads_locked, class_name: 'CommentThread', foreign_key: :locked_by_id, dependent: :nullify
   has_many :category_filter_defaults, dependent: :destroy
   has_many :filters, dependent: :destroy
+  has_many :user_websites, dependent: :destroy
+  accepts_nested_attributes_for :user_websites
   belongs_to :deleted_by, required: false, class_name: 'User'
 
   validates :username, presence: true, length: { minimum: 3, maximum: 50 }
@@ -130,6 +133,10 @@ def website_domain
     website.nil? ? website : URI.parse(website).hostname
   end
 
+  def websites_for
+    user_websites.order(position)
+  end
+
   def is_moderator
     is_global_moderator || community_user&.is_moderator || is_admin || community_user&.privilege?('mod') || false
   end

app/models/user_website.rb

@@ -0,0 +1,5 @@
+class UserWebsite < ApplicationRecord
+
+  belongs_to :user
+
+end

app/views/users/edit_profile.html.erb

@@ -44,6 +44,24 @@
   <p>Note: Links are not shown publicly until you have earned the Participate Everywhere ability.</p>
   <div class="post-preview"></div>
 
+  <div>
+    <p>External links (your web site, blog, social media, GitHub, etc)</p>
+    <div class="grid">
+      <%= f.fields_for :user_websites do |w| %>
+      <div class="grid grid--cell is-12">
+	<div class="grid grid--cell is-4">
+	  <div class="grid--cell is-2">Label:</div>
+	  <div class="grid--cell is-10"><%= w.text_field :label, class: 'form-element' %></div>
+	</div>
+	<div class="grid grid--cell is-6">
+	  <div class="grid--cell is-1">URL:</div>
+          <div class="grid--cell is-11"><%= w.text_field :url, class: 'form-element' %></div>
+	</div>
+      </div>
+      <% end %>
+    </div>
+  </div>
+
   <div class="grid">
     <div class="grid--cell is-4 is-12-sm form-group">
       <%= f.label :website, class: "form-element" %>

app/views/users/show.html.erb

@@ -57,6 +57,20 @@
       <% end %>
       </div>
 
+      <% if @user.user_websites.size > 0 %>
+      <div>
+	<p><strong>External links</strong></p>
+	<table class="table is-with-hover">
+	  <% @user.user_websites.first(3).each do |w| %>
+	  <tr>
+	    <td><%= w.label %></td>
+	    <td><%= link_to w.url, w.url, rel: 'nofollow' %></td>
+	  </tr>
+	  <% end %>
+	</table>
+      </div>
+      <% end %>
+
       <div class="button-list h-p-2">
         <% if user_signed_in? %>
           <%= link_to new_subscription_path(type: 'user', qualifier: @user.id, return_to: request.path), class: "button is-outlined is-small" do %>

db/migrate/20250123141400_create_user_websites.rb

@@ -0,0 +1,11 @@
+class CreateUserWebsites < ActiveRecord::Migration[7.0]
+  def change
+    create_table :user_websites do |t|
+      t.column :label, :string, limit:80
+      t.string :url
+      t.integer :position
+    end
+    add_reference :user_websites, :user, null: false, foreign_key: true
+    add_index(:user_websites, [:user_id, :url], unique: true)
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.0].define(version: 2024_10_20_193053) do
+ActiveRecord::Schema[7.0].define(version: 2025_01_23_141400) do
   create_table "abilities", charset: "utf8mb4", collation: "utf8mb4_0900_ai_ci", force: :cascade do |t|
     t.bigint "community_id"
     t.string "name"
@@ -684,6 +684,15 @@
     t.index ["community_user_id"], name: "index_user_abilities_on_community_user_id"
   end
 
+  create_table "user_websites", charset: "utf8mb4", collation: "utf8mb4_unicode_ci", force: :cascade do |t|
+    t.string "label", limit: 80
+    t.string "url"
+    t.integer "position"
+    t.bigint "user_id", null: false
+    t.index ["user_id", "url"], name: "index_user_websites_on_user_id_and_url", unique: true
+    t.index ["user_id"], name: "index_user_websites_on_user_id"
+  end
+
   create_table "users", charset: "utf8mb4", collation: "utf8mb4_unicode_ci", force: :cascade do |t|
     t.string "email"
     t.string "encrypted_password"
@@ -826,6 +835,7 @@
   add_foreign_key "thread_followers", "posts"
   add_foreign_key "user_abilities", "abilities"
   add_foreign_key "user_abilities", "community_users"
+  add_foreign_key "user_websites", "users"
   add_foreign_key "users", "users", column: "deleted_by_id"
   add_foreign_key "votes", "communities"
   add_foreign_key "warning_templates", "communities"