Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

177 motion control create new differentialdrive class #179

Merged

Conversation

mlecriva
Copy link
Contributor

@mlecriva mlecriva commented Dec 5, 2024

The purpose of this interface is to define a common interface used by
platform engine in order to use any kind of drive controller (eg.
DifferentialDrive or HolonomicDrive)

The interface provides one method to set polar robot velocity.

COGIP robots are differential. So, implement the differential drive
controller in order to convert robot polar speed into speed ratio for
each motors.

The speed ratio is defined using the motor electrical information found
in the datasheet. This ratio reflect the percentage of nominal motor
voltage to apply in order to reach the velocity wanted.

@mlecriva mlecriva linked an issue Dec 5, 2024 that may be closed by this pull request
@mlecriva mlecriva requested review from gdoffe and ecourtois December 5, 2024 12:22
@mlecriva mlecriva force-pushed the 177-motion-control-create-new-differentialdrive-class branch from 04c994f to 4ed720c Compare December 5, 2024 12:30
@mlecriva mlecriva force-pushed the 177-motion-control-create-new-differentialdrive-class branch 2 times, most recently from 9bba344 to 344fb3b Compare January 27, 2025 20:54
The purpose of this class is to define a common interface used by
platform engine in order to use any kind of drive controller (eg.
DifferentialDrive or HolonomicDrive)

This interface provides one method to set polar robot velocity.

Signed-off-by: Mathis Lécrivain <[email protected]>
@mlecriva mlecriva force-pushed the 177-motion-control-create-new-differentialdrive-class branch 2 times, most recently from 24da99a to db9c870 Compare January 27, 2025 20:58
COGIP robots are differential. So, implement the differential drive
controller in order to convert robot polar speed into speed ratio for
each motors.

The speed ratio is defined using the motor electrical informations found
in the datasheet. This ratio reflects the percentage of nominal motor
voltage to apply in order to reach the velocity wanted.

Signed-off-by: Mathis Lécrivain <[email protected]>
@mlecriva mlecriva force-pushed the 177-motion-control-create-new-differentialdrive-class branch from db9c870 to 1f753f4 Compare January 27, 2025 21:03
Copy link
Contributor

@gdoffe gdoffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now ! Good job !

@mlecriva mlecriva merged commit 540390e into master Jan 27, 2025
1 check passed
@mlecriva mlecriva deleted the 177-motion-control-create-new-differentialdrive-class branch January 27, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Motion Control - Create new DifferentialDrive class
2 participants