-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
177 motion control create new differentialdrive class #179
Merged
mlecriva
merged 2 commits into
master
from
177-motion-control-create-new-differentialdrive-class
Jan 27, 2025
Merged
177 motion control create new differentialdrive class #179
mlecriva
merged 2 commits into
master
from
177-motion-control-create-new-differentialdrive-class
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04c994f
to
4ed720c
Compare
gdoffe
requested changes
Jan 25, 2025
motion_control/drive_controller/include/drive_controller/DriveControllerInterface.hpp
Outdated
Show resolved
Hide resolved
motion_control/drive_controller/include/drive_controller/DifferentialDriveController.hpp
Show resolved
Hide resolved
motion_control/drive_controller/include/drive_controller/DifferentialDriveController.hpp
Show resolved
Hide resolved
motion_control/drive_controller/include/drive_controller/DifferentialDriveController.hpp
Outdated
Show resolved
Hide resolved
..._control/drive_controller/include/drive_controller/DifferentialDriveControllerParameters.hpp
Outdated
Show resolved
Hide resolved
..._control/drive_controller/include/drive_controller/DifferentialDriveControllerParameters.hpp
Outdated
Show resolved
Hide resolved
..._control/drive_controller/include/drive_controller/DifferentialDriveControllerParameters.hpp
Show resolved
Hide resolved
..._control/drive_controller/include/drive_controller/DifferentialDriveControllerParameters.hpp
Show resolved
Hide resolved
..._control/drive_controller/include/drive_controller/DifferentialDriveControllerParameters.hpp
Show resolved
Hide resolved
9bba344
to
344fb3b
Compare
The purpose of this class is to define a common interface used by platform engine in order to use any kind of drive controller (eg. DifferentialDrive or HolonomicDrive) This interface provides one method to set polar robot velocity. Signed-off-by: Mathis Lécrivain <[email protected]>
24da99a
to
db9c870
Compare
COGIP robots are differential. So, implement the differential drive controller in order to convert robot polar speed into speed ratio for each motors. The speed ratio is defined using the motor electrical informations found in the datasheet. This ratio reflects the percentage of nominal motor voltage to apply in order to reach the velocity wanted. Signed-off-by: Mathis Lécrivain <[email protected]>
db9c870
to
1f753f4
Compare
gdoffe
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now ! Good job !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this interface is to define a common interface used by
platform engine in order to use any kind of drive controller (eg.
DifferentialDrive or HolonomicDrive)
The interface provides one method to set polar robot velocity.
COGIP robots are differential. So, implement the differential drive
controller in order to convert robot polar speed into speed ratio for
each motors.
The speed ratio is defined using the motor electrical information found
in the datasheet. This ratio reflect the percentage of nominal motor
voltage to apply in order to reach the velocity wanted.