feat: Add Funding Support #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
alex-stone
force-pushed
the
stone/funding
branch
from
b818a89 to
efdeed9
Compare
alex-stone
force-pushed
the
stone/funding
branch
2 times, most recently
from
a867854 to
a189a0d
Compare
| # @param wallet_id [String] The Wallet ID of the sending Wallet | ||
| # @param amount [BigDecimal] The amount of the Asset to send | ||
| # @param network [Coinbase::Network, Symbol] The Network or Network ID of the Asset | ||
| # @param asset_id [Symbol] The Asset ID of the Asset to send |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
alex-stone
force-pushed
the
stone/funding
branch
4 times, most recently
from
ba63456 to
830d259
Compare
This adds a CryptoAmount types that provides a wrapper for the underlying CryptoAmount object and can provide helpers for converting from atomic to whole amounts. This provides a FiatAmount type as well to wrap our fiat amount + currency pairings in a consistent manner.
This adds support for generating a quote of a wallet fund operation. This will be able to be used to execute a fund operation soon.
This adds support for funding wallets using `wallet.fund` or `address.fund`. This will be extended to support leveraging a fund quote in a subsequent commit.
alex-stone
force-pushed
the
stone/funding
branch
from
830d259 to
05c8eb0
Compare
This makes it so that after you generate a fund quote and verify the amounts and fees make sense to you, you can execute that quote. Note: If it has been a while the quote may expire and we will return an error indicating that to you.
alex-stone
force-pushed
the
stone/funding
branch
from
05c8eb0 to
cd1391e
Compare
This fixes the rendering for Balance, CryptoAmount, and FiatAmount, to print out the BigDecimals as a float. They were erroneously printing the `amount` as an integer, which removes the precision unnecessarily.
rohan-agarwal-coinbase
approved these changes
Nov 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This adds support for funding wallets for a given Crypto Asset and amount, using your Coinbase accounts as the source of funds to buy the asset.
Note:: This is an Alpha feature and you must reach out on the CDP SDK Discord to opt in.
This enables quoting a fund operation
Creating a fund quote and then executing it:
Fund a wallet
Qualified Impact