chore: Increase Wallet dropdown SVG sizes to 18x18 #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cpcramer
changed the title
Zizzamia
reviewed
Aug 13, 2024
| @@ -35,7 +35,7 @@ export function WalletDropdownLink({ | |||
| target={target} | |||
| rel={rel} | |||
| > | |||
| <div className="-translate-y-1/2 absolute top-1/2 left-4 flex h-4 w-4 items-center justify-center"> | |||
| <div className="-translate-y-1/2 absolute top-1/2 left-4 flex h-[1.125rem] w-[1.125rem] items-center justify-center"> | |||
There was a problem hiding this comment.
rem? are we sure this is stable? rem usually is relative to the screen.
There was a problem hiding this comment.
The previous setting (h-4 and w-4) are also using REM
Zizzamia
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Increase our wallet logo sizes from 16x16 to 18x18.
How has it been tested?