Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Increase Wallet dropdown SVG sizes to 18x18 #1041

Merged
merged 3 commits into from
Aug 13, 2024
Merged

chore: Increase Wallet dropdown SVG sizes to 18x18 #1041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17b2a2b
chore: Increase logo size to 18x18
cpcramer Aug 13, 2024
4583c48
Changeset
cpcramer Aug 13, 2024
6d6c7c2
lint
cpcramer Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changeset/many-ravens-cry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@

-**chore**: Add testing to Transaction Toast. By @cpcramer #1023
-**chore**: Add Connect Wallet tests and refactor to use Vitest. By @cpcramer #1036
-**chore**: Increase Wallet dropdown png size to 18x18. By @cpcramer #1041
2 changes: 1 addition & 1 deletion src/wallet/components/WalletDropdownBaseName.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function WalletDropdownBaseName({
target="_blank"
rel="noopener noreferrer"
>
<div className="-translate-y-1/2 absolute top-1/2 left-4 flex h-4 w-4 items-center justify-center">
<div className="-translate-y-1/2 absolute top-1/2 left-4 flex h-[1.125rem] w-[1.125rem] items-center justify-center">
{baseNameSvg}
</div>
<div className="flex w-full items-center pl-6">
Expand Down
2 changes: 1 addition & 1 deletion src/wallet/components/WalletDropdownDisconnect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export function WalletDropdownDisconnect({
)}
onClick={handleDisconnect}
>
<div className="-translate-y-1/2 absolute top-1/2 left-4 flex h-4 w-4 items-center justify-center">
<div className="-translate-y-1/2 absolute top-1/2 left-4 flex h-[1.125rem] w-[1.125rem] items-center justify-center">
{disconnectSvg}
</div>
<span className={cn(dsText.body, 'pl-6')}>{text}</span>
Expand Down
2 changes: 1 addition & 1 deletion src/wallet/components/WalletDropdownLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export function WalletDropdownLink({
target={target}
rel={rel}
>
<div className="-translate-y-1/2 absolute top-1/2 left-4 flex h-4 w-4 items-center justify-center">
<div className="-translate-y-1/2 absolute top-1/2 left-4 flex h-[1.125rem] w-[1.125rem] items-center justify-center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rem? are we sure this is stable? rem usually is relative to the screen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous setting (h-4 and w-4) are also using REM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-08-12 at 5 18 41 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-08-12 at 5 19 12 PM

{iconSvg}
</div>
<span className={cn(text.body, 'pl-6')}>{children}</span>
Expand Down