wip: debugging #148
Closed
wip: debugging #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zizzamia
reviewed
Feb 20, 2024
Zizzamia
reviewed
Feb 20, 2024
Zizzamia
reviewed
Feb 20, 2024
| messageOptions?: FrameMessageOptions, | ||
| ): Promise<FrameValidationResponse> { | ||
| // Skip validation only when allowed and when receiving a debug request | ||
| if (messageOptions?.allowDebug) { |
There was a problem hiding this comment.
if this is a boolean, we should either use has or is as prefix.
so maybe isMockRequest: boolean
There was a problem hiding this comment.
In this case, not every request is necessarily a mock request. I think it's most clear as is: if set, it will allow mock requests to pass through, otherwise it will reject them.
Zizzamia
reviewed
Feb 20, 2024
| @@ -3179,6 +3191,7 @@ __metadata: | |||
| version: 0.0.0-use.local | |||
| resolution: "framegear@workspace:." | |||
| dependencies: | |||
| "@coinbase/onchainkit": "portal:./.." | |||
There was a problem hiding this comment.
Inteeeeerestinggggggggg
What the heck which magic is this?
There was a problem hiding this comment.
There was a problem hiding this comment.
Once we finalize probably want to specify the exact version, but this is great for dev
There was a problem hiding this comment.
Now you're thinking with portals
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?