feat: framegear can test some frames locally #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zizzamia
approved these changes
Feb 20, 2024
Zizzamia
deleted the
cjn/look-upon-my-framegear-ye-mighty-and-despair
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Pulled from #148. Using the changes from #149, this PR extends
framegearto be able to test some frames locally. We don't yet have full coverage, but frames that simply use thepostaction on buttons work (provided that they are built with v0.8.0+ of@coinbase/onchainkitand that they pass theallowFramegearoption togetFrameMessage. Documentation around this functionality is in progress).Additionally updated docs site to include usage notes.
#146 tracks future enhancements, including being able to simulate likes/follows/recasts and handling other types of button action.
Screen.Recording.2024-02-19.at.10.58.17.PM.mov
Notes to reviewers
LFG
How has it been tested?
I took a-frame-in-100-lines, modified it to use the new code, and tested that I could advance through frames using buttons with the
postaction.