feat: Implement WalletDropdownBaseName Sub-Component #913
Conversation
github-actions
bot
added
documentation
cpcramer
changed the title
cpcramer
changed the title
|
@cpcramer could you rebase from main when you have a minute? With all our tests in order, it'll help our CI pass more easily. |
cpcramer
force-pushed
the
paul/add-base-name
branch
from
9ace7e5 to
d5541a4
Compare
|
@Zizzamia Rebased ✅ |
|
@cpcramer let's make sure the CI Test check is passing. |
cpcramer
force-pushed
the
paul/add-base-name
branch
from
d5541a4 to
ddc0fac
Compare
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
| import type { WalletDropdownBaseNameReact } from '../types'; | ||
|
|
||
| export function WalletDropdownBaseName({ | ||
| className, |
There was a problem hiding this comment.
There are some extra customization we might want to add here as follow up PR. I let you think on this.
cpcramer
force-pushed
the
paul/add-base-name
branch
from
3646933 to
e76fe1d
Compare
| chain: base, | ||
| }); | ||
|
|
||
| let hasBaseUserName = false; |
There was a problem hiding this comment.
Should this be
const hasBaseUserName = !!baseName;
???
There was a problem hiding this comment.
It could be. I actually refactored that to what you see now because I thought that !! was confusing syntax
There was a problem hiding this comment.
I feel like what I have now is easier to read. But happy to update to !!baseName
cpcramer
force-pushed
the
paul/add-base-name
branch
from
0e5d5f3 to
f69b963
Compare
What changed? Why?
Add the Base Name tab to the Wallet Component. When a user has a Base Name, this tab will direct them to their Base Name profile page. If a user does not have a Base Name, this tab will direct them to a page where they can create one!
WalletDropdownBaseNamecomponentWalletDropdownBaseNametestsVideo recording:
Wallet Components & Utilities · OnchainKit - 27 July 2024 - Watch Video
Notes to reviewers
How has it been tested?