Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Implement WalletDropdownBaseName Sub-Component #916

Merged
merged 22 commits into from
Aug 12, 2024

Conversation

cpcramer
Copy link
Contributor

@cpcramer cpcramer commented Jul 27, 2024

What changed? Why?

Add the Base Name tab to the Wallet Component. When a user has a Base Name, this tab will direct them to their Base Name profile page. If a user does not have a Base Name, this tab will direct them to a page where they can create one!

  • Add new basenames user icon.
  • Update landing page wallet component to use Basenames.
  • Update the wallet, Avatar, getAvatar, Name, and getName docs with Basenames examples.
Part Description Status
1 feat: Implement WalletDropdownBaseName Sub-Component #913
2 docs: Implement WalletDropdownBaseName Sub-Component #916 In Progress

Video recording:
Wallet Components & Utilities · OnchainKit - 27 July 2024 - Watch Video

Note that the Wallet and Basenames tabs are flipped in prod - Wallet is above Basenames.
Screenshot 2024-08-12 at 2 02 14 PM

Screenshot 2024-08-12 at 2 02 01 PM Screenshot 2024-08-12 at 2 02 42 PM Screenshot 2024-08-12 at 2 02 55 PM

/wallet/wallet:
Screenshot 2024-08-12 at 2 09 13 PM

Screenshot 2024-08-12 at 2 22 03 PM Screenshot 2024-08-12 at 2 30 40 PM Screenshot 2024-08-12 at 2 34 36 PM Screenshot 2024-08-12 at 2 34 43 PM Screenshot 2024-08-12 at 2 38 35 PM Screenshot 2024-08-12 at 4 03 15 PM

Notes to reviewers

How has it been tested?
I've done end user testing (screenshot contains old UI but the functionality is the same.):
Screenshot 2024-07-30 at 4 55 37 PM

@github-actions github-actions bot added documentation Improvements or additions to documentation pkg: wallet labels Jul 27, 2024
@cpcramer cpcramer changed the title Paul/add base name docs docs: Implement WalletDropdownBaseName Sub-Component Jul 27, 2024
@Zizzamia
Copy link
Contributor

@cpcramer could you rebase from main when you have a minute? With all our tests in order, it'll help our CI pass more easily.

Copy link

vercel bot commented Jul 30, 2024

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this project.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

Copy link

vercel bot commented Aug 12, 2024

You must have Developer access to commit code to Coinbase on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

@cpcramer cpcramer force-pushed the paul/add-base-name-docs branch from d9f642f to c0e0bea Compare August 12, 2024 20:37
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 12, 2024 11:29pm

@Zizzamia Zizzamia merged commit e8887bc into main Aug 12, 2024
14 checks passed
@Zizzamia Zizzamia deleted the paul/add-base-name-docs branch August 12, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation pkg: wallet
Development

Successfully merging this pull request may close these issues.

2 participants