Adds SSL support #140
Closed
Adds SSL support #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables the use of mTLS for client<>server communication. https://docs.temporal.io/docs/server/security/#encryption-in-transit-with-mtls An update of coinbase#73 to close coinbase#70
antstorm
suggested changes
Feb 21, 2022
There was a problem hiding this comment.
Thank you for resurrecting this, @cvanderschuere ! Left few comments, but similar to the original PR this needs unit specs to test the new behaviour
|
@antstorm mind taking another look? |
|
Hi, is it possible to finish and merge this? I'd be happy to help. @antstorm, any other changes needed here? |
Merged
|
Completed with #186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70
This PR is an update of #73 to work after the client/connection split.
This change enables the use of mTLS for client<>server communication.