Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gRPC credentials #186

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Add gRPC credentials #186

merged 5 commits into from
Jun 24, 2022

Conversation

jlemesh
Copy link
Contributor

@jlemesh jlemesh commented Jun 22, 2022

Closes #70

Third attempt at adding SSL support. Previous attempts died: #73 and #140

Bonus: allows adding OAuth2 tokens using same gRPC credentials.

@jlemesh
Copy link
Contributor Author

jlemesh commented Jun 22, 2022

temporalio/auto-setup container fails with error Unable to create dynamic config client. Error: unable to validate dynamic config: dynamic config: config/dynamicconfig/development.yaml: stat config/dynamicconfig/development.yaml: no such file or directory

@jlemesh
Copy link
Contributor Author

jlemesh commented Jun 22, 2022 •
edited
Loading

RSpec: Received "interrupt" signal ¯\_(ツ)_/¯

antstorm
antstorm approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@antstorm antstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @jlemesh, thank you! 👍

@DeRauk DeRauk merged commit 78e4fb8 into coinbase:master Jun 24, 2022
@cvanderschuere cvanderschuere mentioned this pull request Jul 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antstorm antstorm antstorm approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSL Support for GRPC Client
3 participants
@jlemesh @antstorm @DeRauk