Skip to content

Conversation

@TheSecurityDev
Copy link
Contributor

@TheSecurityDev TheSecurityDev commented Oct 14, 2025

Screenshots for uppercase, number, and symbol layouts. There should also be one with text, which I had but reverted for simplicity.

We could also add one for password mode, but it might not be as important.

Copilot AI review requested due to automatic review settings October 14, 2025 06:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds screenshot test coverage for additional keyboard states including uppercase, numbers, and symbols modes with typed text examples.

  • Adds helper functions to interact with different keyboard modes (shift, numbers toggle)
  • Creates setup functions for three new keyboard test scenarios with different states
  • Registers the new keyboard test scenarios in the setup function mapping

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the ui label Oct 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

raylib UI Preview

keyboard : $${\color{red}\text{DIFFERENT}}$$
master proposed
diff composite diff
keyboard_caps_lock : $${\color{cyan}\text{NEW}}$$
keyboard_numbers : $${\color{cyan}\text{NEW}}$$
keyboard_symbols : $${\color{cyan}\text{NEW}}$$
keyboard_uppercase : $${\color{cyan}\text{NEW}}$$
All Screenshots

@TheSecurityDev TheSecurityDev marked this pull request as draft October 14, 2025 06:56
@TheSecurityDev TheSecurityDev marked this pull request as ready for review October 14, 2025 07:27
@TheSecurityDev
Copy link
Contributor Author

This would actually be quite useful for the keyboard bug fixes

@TheSecurityDev TheSecurityDev changed the title Add screenshots for more keyboard states Add screenshots for more keyboard layouts Oct 15, 2025
@maxime-desroches
Copy link
Collaborator

Can you also add the double tap on caps so you get caps lock?

@TheSecurityDev
Copy link
Contributor Author

Can you also add the double tap on caps so you get caps lock?

Done. And I added text to the default screenshot. Is that good enough? Or should that be a separate screenshot.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Nov 1, 2025
@TheSecurityDev
Copy link
Contributor Author

Bump

@github-actions github-actions bot removed the stale label Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants