raylib screenshots: fix and include pair device screenshot #36394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the pair device screenshot functionality in the raylib UI tests and includes it in the screenshot comparison workflow while skipping its diff check. The changes ensure the pair device screen is properly navigated to and captured, while preventing CI failures from expected differences in this screen.
Key Changes:
- Updated the setup function for pair device screenshots to use the correct navigation path
- Modified the GitHub workflow to include pair_device screenshots in the output but skip their diff comparison
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| selfdrive/ui/tests/test_ui/raylib_screenshots.py | Fixed navigation to pair device screen by calling setup_settings first and adjusting click coordinates |
| .github/workflows/ui_preview.yaml | Removed grep filter and added conditional logic to skip diff check for pair_device screenshots |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
raylib UI PreviewAll Screenshots
|
|
Bruh I've been modifying the old ui_preview workflow, no wonder it wasn't working 🤦 |
|
I can't make it work :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#36393, but should also include the screenshot in the list of all screenshots, only skipping the diff check.
There were reports of a QR code error, so it would be nice to know if that happens.
.