BTHAB-180: Only perform delete if id line item is not empty #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olayiwola-compucorp
approved these changes
Sep 11, 2023
erawat
force-pushed
the
BTHAB-180-only-remove-if-not-empty
branch
from
c5aa13c
to
54f2773
Compare
erawat
force-pushed
the
BTHAB-180-only-remove-if-not-empty
branch
from
54f2773
to
dbe0ae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the logic to prevent deleting SaleOrderLine objects when there isn't any ID attaches to the SaleOrder['items'] which will cause the error as we are passing an empty array to the query.
This scenario is likely to happen when the API caller want to update a sale order/quotation with a new list of product items, where the product items have not been created yet.