Major refactor and cleanup for improved stability #80
Conversation
mattwire
force-pushed
the
mjwconsulting
branch
2 times, most recently
from
58865b0
to
2a622d2
Compare
|
This branch throws an error when "Adding to the batch"
|
…pdating contribution
|
@tapashdatta Thanks - that should be resolved - there was an issue with the schema definition. |
mattwire
force-pushed
the
mjwconsulting
branch
4 times, most recently
from
ee738bc
to
2047f6e
Compare
docs/release/release_notes.md
Outdated
| @@ -0,0 +1,21 @@ | |||
| ## Release 3.3 | |||
| **In this release we update profiles to use the declaration eligibility field instead of the contribution. | |||
There was a problem hiding this comment.
@mattwire I'm not sure I understand this change? Does this mean the field "eligible for gift aid" on the contribution is no longer used? I think users need this to find the contributions that should be eligible for gift aid to add to batch...
There was a problem hiding this comment.
The user needs to create a gift aid declaration - and there are situations where you want to create a gift aid declaration but not apply it to the contribution. By displaying the declaration Yes/Yes past 4 years/No to the user they are explicitly updating the declaration and contributions will by default use that. The contribution now has "Yes/No" because the 3rd option makes no sense at a contribution level.
mattwire
force-pushed
the
mjwconsulting
branch
from
3a4b0a4
to
a53e161
Compare
…r in PHP meaning that we always ensure they are up to date with the latest extension
Improve documentation
Fix install notices
…bly doesn't work anymore and adds complexity to the code.
Fix install setting default batch when it shouldn't; add first two tests
Add more thorough tests for set eligibility and fix an issue found
…ed-at-runtime Handle multiple contribs created at runtime
We've done some major refactoring to make this extension much more stable and update it to the latest coding standards / requirements. And added a feature to automatically calculate the gift-aid amount when creating/editing contributions.
Changes:
Features: