Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major refactor and cleanup for improved stability #80

Open
wants to merge 84 commits into
base: master
Choose a base branch
from
Open

Major refactor and cleanup for improved stability #80

wants to merge 84 commits into from

Commits on Jun 30, 2019

  1. Calculate gift aid when creating/editing contribution

    @mattwire
    mattwire committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    4f1953e View commit details
    Browse the repository at this point in the history

  2. Convert to short array syntax

    @mattwire
    mattwire committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    c74d6e6 View commit details
    Browse the repository at this point in the history

  3. Update civix

    @mattwire
    mattwire committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    72b6012 View commit details
    Browse the repository at this point in the history

  4. Major cleanup and refactor. Calculate gift aid amount when creating/u… 

    …pdating contribution
    @mattwire
    mattwire committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    65759c5 View commit details
    Browse the repository at this point in the history

  5. Be stricter checking eligible_for_gift_aid variable type

    @mattwire
    mattwire committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    6e5acd0 View commit details
    Browse the repository at this point in the history

  6. Fix issues with entity definition and regenerate

    @mattwire
    mattwire committed Jun 30, 2019
    Configuration menu
    Copy the full SHA
    f1e6388 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. Fix PHP notice

    @mattwire
    mattwire committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    2ef45c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2019

  1. Refactor addtobatch for performance, refactor upgrader for reliability

    @mattwire
    mattwire committed Jul 28, 2019
    Configuration menu
    Copy the full SHA
    8f70f2e View commit details
    Browse the repository at this point in the history

  2. Add API to update the eligible_for_gift_aid flag on contributions

    @mattwire
    mattwire committed Jul 28, 2019
    Configuration menu
    Copy the full SHA
    8da262b View commit details
    Browse the repository at this point in the history

  3. Version info

    @mattwire
    mattwire committed Jul 28, 2019
    Configuration menu
    Copy the full SHA
    a1c2b8e View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2019

  1. Fix status message on AddToBatch

    @mattwire
    mattwire committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    c1e071c View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2019

  1. Fix enable/disable

    @mattwire
    mattwire committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    a81f615 View commit details
    Browse the repository at this point in the history

  2. Refactor insert/updateDeclaration

    @mattwire
    mattwire committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    be39d34 View commit details
    Browse the repository at this point in the history

  3. Add upgrader

    @mattwire
    mattwire committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    0b0953e View commit details
    Browse the repository at this point in the history

  4. Refactor loading of optiongroups/values - we load them in the upgrade… 

    …r in PHP meaning that we always ensure they are up to date with the latest extension
    @mattwire
    mattwire committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    d43134f View commit details
    Browse the repository at this point in the history

  5. Fix PHP notice

    @mattwire
    mattwire committed Aug 22, 2019
    Configuration menu
    Copy the full SHA
    b124979 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2019

  1. Handle creating declaration, then ending, then creating another prope… 

    …rly (set end_date etc properly)
    @mattwire
    mattwire committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    200b967 View commit details
    Browse the repository at this point in the history

  2. Allow for both declaration eligibility and individual contribution el… 

    …igibility to be different on same profile
    @mattwire
    mattwire committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    79d308a View commit details
    Browse the repository at this point in the history

  3. Fix PHP notice in GiftAid report

    @mattwire
    mattwire committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    4368339 View commit details
    Browse the repository at this point in the history

  4. Match on OptionValue value when running upgrader as name is not alway… 

    …s consistent
    @mattwire
    mattwire committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    f9af706 View commit details
    Browse the repository at this point in the history

  5. Update docs for 3.3

    @mattwire
    mattwire committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    ac7979f View commit details
    Browse the repository at this point in the history

  6. Add basic docs on the gift aid declaration

    @mattwire
    mattwire committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    6e125d2 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Major performance improvement to 'Add to Batch'

    @mattwire
    mattwire committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    dc9908f View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2019

  1. Release 3.3.2 - equivalent to compucorp 3.1.0 release

    @mattwire
    mattwire committed Dec 27, 2019
    Configuration menu
    Copy the full SHA
    63a9977 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2020

  1. Extract code to check if charity column exists

    @mattwire
    mattwire committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    62501e8 View commit details
    Browse the repository at this point in the history

  2. Properly escape SQL parameters when updating gift aid declaration

    @mattwire
    mattwire committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    a50877d View commit details
    Browse the repository at this point in the history

  3. Refactor creating/updating declaration when contribution is created/u… 

    …pdated
    @mattwire
    mattwire committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    e84f788 View commit details
    Browse the repository at this point in the history

  4. Handle transitions between the 3 declaration states without losing in… 

    …formation - create a new declaration when state is changed
    @mattwire
    mattwire committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    c514357 View commit details
    Browse the repository at this point in the history

  5. Create FUNDING.yml

    @mattwire
    mattwire committed Feb 23, 2020
    Configuration menu
    Copy the full SHA
    d3c378b View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Update version

    @mattwire
    mattwire committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    8cffa8c View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Always make sure current declaration is set if we have one - fixes is… 

    …sue with overwriting declaration with 'No'
    @mattwire
    mattwire committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    ad2db77 View commit details
    Browse the repository at this point in the history

  2. tweak update

    @mattwire
    mattwire committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    e514787 View commit details
    Browse the repository at this point in the history

  3. Check and set label for 'Eligible amount' field on contribution

    @mattwire
    mattwire committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    165a5ed View commit details
    Browse the repository at this point in the history

  4. Clear batch_name if we created a new contribution in a recur series (… 

    …it's copied across by default by Contribution.repeattransaction)
    @mattwire
    mattwire committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    598d420 View commit details
    Browse the repository at this point in the history

  5. Include first donation in the batch 

    Due to the timestamp on the declaration is created after the contribution hence the first donation doesn't gets included in batch. Set the timestamp as the date rather than time
    @tapashdatta
    tapashdatta authored Apr 7, 2020
    Configuration menu
    Copy the full SHA
    9e22eca View commit details
    Browse the repository at this point in the history

  6. Merge pull request #8 from tapashdatta/patch-2 

    Include first donation in the batch
    @mattwire
    mattwire authored Apr 7, 2020
    Configuration menu
    Copy the full SHA
    5c0be5f View commit details
    Browse the repository at this point in the history

  7. Trigger create of new gift aid declaration from contribution form if … 

    …required.
    @mattwire
    mattwire committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    6f181f4 View commit details
    Browse the repository at this point in the history

  8. Fix #5 Donations included in batch although financial types disabled … 

    …in settings
    @mattwire
    mattwire committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    2eba6dd View commit details
    Browse the repository at this point in the history

  9. Release 3.3.3

    @mattwire
    mattwire committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    8c5e882 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2020

  1. Release 3.3.4 - fix setting 'eligible for gift aid' on contribution

    @mattwire
    mattwire committed Apr 15, 2020
    Configuration menu
    Copy the full SHA
    da2659a View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. Update copyright headers

    @mattwire
    mattwire committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    4c20b82 View commit details
    Browse the repository at this point in the history

  2. Update and refactor how we create/update declarations

    @mattwire
    mattwire committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    3a95a72 View commit details
    Browse the repository at this point in the history

  3. Release 3.3.5

    @mattwire
    mattwire committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    eda2229 View commit details
    Browse the repository at this point in the history

  4. Update GiftAid.updateeligiblecontributions API and document

    @mattwire
    mattwire committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    7f7eb6a View commit details
    Browse the repository at this point in the history

  5. Rework Add to Batch to improve performance and ensure that what is sh… 

    …own on the screen is what is added
    @mattwire
    mattwire committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    9b28703 View commit details
    Browse the repository at this point in the history

  6. Rework Remove from Batch to improve performance and ensure that what … 

    …is shown on the screen is what is added
    @mattwire
    mattwire committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    fe64371 View commit details
    Browse the repository at this point in the history

  7. Release 3.3.6

    @mattwire
    mattwire committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    90bb338 View commit details
    Browse the repository at this point in the history

  8. Allow editing address on the declaration

    @mattwire
    mattwire committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    c90a15f View commit details
    Browse the repository at this point in the history

  9. Release 3.3.7

    @mattwire
    mattwire committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    f8f3e6a View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2020

  1. Release 3.3.8 - Refactor GiftAid report to fix multiple issues and sh… 

    …ow batches with multiple financial types
    @mattwire
    mattwire committed Apr 17, 2020
    Configuration menu
    Copy the full SHA
    fac3127 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2020

  1. Use callback when setting contribution gift aid eligibility

    @mattwire
    mattwire committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    c928985 View commit details
    Browse the repository at this point in the history

  2. Release 3.3.9

    @mattwire
    mattwire committed Apr 27, 2020
    Configuration menu
    Copy the full SHA
    83e7da1 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2020

  1. Use session to track giftaid selections on form so it works with conf… 

    …irmation page
    @mattwire
    mattwire committed May 4, 2020
    Configuration menu
    Copy the full SHA
    7833f38 View commit details
    Browse the repository at this point in the history

  2. Only display eligible but no declaration message if logged in and has… 

    … access to civicontribute
    @mattwire
    mattwire committed May 4, 2020
    Configuration menu
    Copy the full SHA
    69bf790 View commit details
    Browse the repository at this point in the history

  3. Release 3.3.10

    @mattwire
    mattwire committed May 4, 2020
    Configuration menu
    Copy the full SHA
    884d55b View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Improve documentation

    Rich Lott / Artful Robot committed May 5, 2020
    Configuration menu
    Copy the full SHA
    69411d0 View commit details
    Browse the repository at this point in the history

  2. get rid of install errors

    Rich Lott / Artful Robot committed May 5, 2020
    Configuration menu
    Copy the full SHA
    2409d66 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Merge pull request #14 from artfulrobot/artfulrobot-improve-docs 

    Improve documentation
    @mattwire
    mattwire authored May 6, 2020
    Configuration menu
    Copy the full SHA
    30c45e5 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #17 from artfulrobot/artfulrobot-fix-install-notices 

    Fix install notices
    @mattwire
    mattwire authored May 6, 2020
    Configuration menu
    Copy the full SHA
    5c5beec View commit details
    Browse the repository at this point in the history

Commits on May 10, 2020

  1. * Remove code to handle multiple charities - it is untested and proba… 

    …bly doesn't work anymore and adds complexity to the code.
    @mattwire
    mattwire committed May 10, 2020
    Configuration menu
    Copy the full SHA
    38c0ce6 View commit details
    Browse the repository at this point in the history

  2. Release 3.3.11

    @mattwire
    mattwire committed May 10, 2020
    Configuration menu
    Copy the full SHA
    91dd82b View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Simplify fetching list of entity_ids

    Rich Lott / Artful Robot committed May 11, 2020
    Configuration menu
    Copy the full SHA
    869aaf2 View commit details
    Browse the repository at this point in the history

  2. Improve code readability and avoid duplicated method calls

    Rich Lott / Artful Robot committed May 11, 2020
    Configuration menu
    Copy the full SHA
    f46a49a View commit details
    Browse the repository at this point in the history

  3. intial tests

    Rich Lott / Artful Robot committed May 11, 2020
    Configuration menu
    Copy the full SHA
    312b6a9 View commit details
    Browse the repository at this point in the history

  4. Add failing tests

    Rich Lott / Artful Robot committed May 11, 2020
    Configuration menu
    Copy the full SHA
    599e369 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2020

  1. Fix install wrongly setting table-level default batch; add first two … 

    …tests
    Rich Lott / Artful Robot committed May 12, 2020
    Configuration menu
    Copy the full SHA
    dbb8331 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #18 from artfulrobot/artfulrobot-tests 

    Fix install setting default batch when it shouldn't; add first two tests
    @artfulrobot
    artfulrobot authored May 12, 2020
    Configuration menu
    Copy the full SHA
    4909903 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Add more tests for set eligibility (one failing due to issue #19)

    Rich Lott / Artful Robot committed May 13, 2020
    Configuration menu
    Copy the full SHA
    99d0ada View commit details
    Browse the repository at this point in the history

  2. Identify eligibility by line items not contribution financial type. F… 

    …ixes issue #19
    Rich Lott / Artful Robot committed May 13, 2020
    Configuration menu
    Copy the full SHA
    dcb85ac View commit details
    Browse the repository at this point in the history

  3. tidy up

    Rich Lott / Artful Robot committed May 13, 2020
    Configuration menu
    Copy the full SHA
    4e7ced3 View commit details
    Browse the repository at this point in the history

  4. First tests on declaration class

    Rich Lott / Artful Robot committed May 13, 2020
    Configuration menu
    Copy the full SHA
    8415193 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Merge pull request #20 from mattwire/artfulrobot-tests 

    Add more thorough tests for set eligibility and fix an issue found
    @mattwire
    mattwire authored May 14, 2020
    Configuration menu
    Copy the full SHA
    78cc43d View commit details
    Browse the repository at this point in the history

Commits on May 15, 2020

  1. fix issue #24 setDeclaration called with missing eligible_for_gift_ai… 

    …d param
    Rich Lott / Artful Robot committed May 15, 2020
    Configuration menu
    Copy the full SHA
    60a3d21 View commit details
    Browse the repository at this point in the history

  2. Add tests for adding all three types of declaration

    Rich Lott / Artful Robot committed May 15, 2020
    Configuration menu
    Copy the full SHA
    e3b37d3 View commit details
    Browse the repository at this point in the history

  3. Add tests for documented declaration logic; clarify docs

    Rich Lott / Artful Robot committed May 15, 2020
    Configuration menu
    Copy the full SHA
    d2dd299 View commit details
    Browse the repository at this point in the history

  4. Tidy/clarify docs

    Rich Lott / Artful Robot committed May 15, 2020
    Configuration menu
    Copy the full SHA
    75dae79 View commit details
    Browse the repository at this point in the history

  5. Add tests for isContributionEligible (good news they pass so far!)

    Rich Lott / Artful Robot committed May 15, 2020
    Configuration menu
    Copy the full SHA
    8b9506c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2020

  1. add another case to contribution eligibility test

    Rich Lott / Artful Robot committed May 16, 2020
    Configuration menu
    Copy the full SHA
    be30022 View commit details
    Browse the repository at this point in the history

  2. Add failing test for issue #26

    Rich Lott / Artful Robot committed May 16, 2020
    Configuration menu
    Copy the full SHA
    fbfde17 View commit details
    Browse the repository at this point in the history

  3. Don't worry about calculating gift aid fields twice

    Rich Lott / Artful Robot committed May 16, 2020
    Configuration menu
    Copy the full SHA
    591528d View commit details
    Browse the repository at this point in the history

  4. Add eligibility flowchart (graphviz .dot format source) - before

    Rich Lott / Artful Robot committed May 16, 2020
    Configuration menu
    Copy the full SHA
    d608e06 View commit details
    Browse the repository at this point in the history

  5. update eligibility flowchart for the case after this PR

    Rich Lott / Artful Robot committed May 16, 2020
    Configuration menu
    Copy the full SHA
    6c327c5 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #27 from mattwire/issue-26-multiple-contribs-creat… 

    …ed-at-runtime

Handle multiple contribs created at runtime
    @mattwire
    mattwire authored May 16, 2020
    Configuration menu
    Copy the full SHA
    0dd6b7c View commit details
    Browse the repository at this point in the history

Commits on May 17, 2020

  1. Update README.md

    @mattwire
    mattwire authored May 17, 2020
    Configuration menu
    Copy the full SHA
    2c43624 View commit details
    Browse the repository at this point in the history