-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
physx: add components #2173
physx: add components #2173
Conversation
All green in build 1 (
|
It is possible to have a target def package_info(self):
self.components["PhysX"].names["cmake_find_package"] = "PhysX"
self.components["PhysX"].libs = ["only-liba"]
self.components["ALL"].names["cmake_find_package"] = "all-dependencies"
self.components["ALL"].requires = ["PhysX"] will create a target |
b48162b
to
5a60532
Compare
Nice, updated. |
Some configurations of 'physx/4.1.1' failed in build 2 (
|
5a60532
to
c81314b
Compare
CI stuck? |
An unexpected error happened and has been reported. Help is on its way! 🏇 |
Now it is running, even though Github doesn't show it |
All green in build 4 (
|
Specify library name and version: physx/all
conan-center hook activated.
Currenrly, PhysX doesn't export its targets, but it should be fixed by NVIDIAGameWorks/PhysX#222
PhysX has a target
PhysX::PhysX
which doesn't depend on all components. With current behaviour of conan, there is no way to properly model this target, since it is reserved for "custom conan global target".Therefore, consumers could only link
PhysX::PhysX
with conan generators, without link errors, while they may have link errors without conan (if they use components not dragged byPhysX::PhysX
, likePhysXExtensions
,PhysXVehicle
,PhysXCooking
andPhysXCharacterKinematic
, and forget to also link them).