Geometry: Select, Points, and Polygon modes #2303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #12706 ↗︎
Details:
Review all test suite changes for PR #2303 ↗︎ |
|||||||||||||||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 186143166-geometry-toolbar #2303 +/- ##
==============================================================
+ Coverage 79.15% 84.41% +5.26%
==============================================================
Files 706 706
Lines 36021 36994 +973
Branches 9190 9604 +414
==============================================================
+ Hits 28511 31229 +2718
+ Misses 7063 5467 -1596
+ Partials 447 298 -149
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closed
bgoldowsky
changed the title
kswenson
approved these changes
May 25, 2024
kswenson
approved these changes
May 28, 2024
| expect(content.getDependents(["p1"], { required: true })).toEqual(["p1"]); | ||
| expect(content.getDependents(["p3"])).toEqual(["p3", polygonId]); | ||
| expect(content.getDependents(["p3"], { required: true })).toEqual(["p3"]); | ||
| const polygonId = polygon?.id; |
There was a problem hiding this comment.
FYI, another approach here would be to assert that it's defined:
Suggested change
| const polygonId = polygon?.id; | |
| const polygonId = polygon!.id; |
And then you wouldn't have to test for it below. Not something I'd recommend in production code but I think it's fine in tests.
bgoldowsky
changed the base branch from
186143166-geometry-toolbar
to
geometry-update
|
This PR is part of the 5.12.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the combined changes from PT-187496223, PT-187496261, and some straggling changes related to PT-186143166 (which was mostly complete in PR #2296).
In points and polygon modes, a "phantom point" is introduced that tracks the mouse pointer. On a click, this becomes a real point.
Logging for all Geometry tile actions was updated to be consistent and account for the new UI.
A minimal Cypress tests of actions in each mode is included; but testing for the Geometry tile could still be improved.