Geometry toolbar #2296
Closed
Geometry toolbar #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed test on run #12580 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Arrow Annotations (Sparrows) > can add arrows to geometry tiles |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #2296 ↗︎
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
- Coverage 84.51% 79.15% -5.37%
==========================================
Files 705 706 +1
Lines 36004 36021 +17
Branches 9189 9190 +1
==========================================
- Hits 30429 28511 -1918
- Misses 5256 7063 +1807
- Partials 319 447 +128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
scytacki
approved these changes
May 11, 2024
| const selectedPoints = selectedObjects?.filter(isPoint); | ||
| const selectedPoint = selectedPoints?.length === 1 ? selectedPoints[0] : undefined; | ||
| const disableVertexAngle = !(selectedPoint && canSupportVertexAngle(selectedPoint)); | ||
| // FIXME toggling this doesn't trigger the "observer" and thus doesn't change the selected state |
There was a problem hiding this comment.
Thank you for reminding me of that. I put in a fix but it seems a bit hacky - can you review and LMK if you see a cleaner way to do it?
bacalj
added a commit
that referenced
this pull request
May 26, 2024
- uses Boris' general button from PR #2296 - updates general toolbar to support above - keeps current image upload mechanism by adding state var to context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the geometry toolbar to the common toolbar framework, and moves it part of the way towards the new spec for now it should work. See notes in PT-186143166.
Pointbutton is added. For the moment point mode just removes the double-click-to-create-a-polygon behavior.Add datais restyled and moved from the title area to the toolbar.Movable lineis removed.Cypress test note -- existing Cypress tests, somehow, passed with these changes. I think that means they are not very comprehensive. I deleted some unit tests for toolbar buttons since they were no longer defined in the same way. Geometry Cypress tests are improved in the next PR (#2303 ).
This has been merged to geometry-update branch