Reenable Cypress test and fix bugs it turned up #2405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2405 +/- ##
==========================================
+ Coverage 86.02% 86.17% +0.14%
==========================================
Files 736 736
Lines 37816 37814 -2
Branches 9623 9626 +3
==========================================
+ Hits 32533 32586 +53
+ Misses 4982 4929 -53
+ Partials 301 299 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
collaborative-learning
|
||||||||||||||||||||||||||||
| Project |
collaborative-learning
|
| Branch Review |
188158639-renable-and-fix-cypress-test
|
| Run status |
|
| Run duration | 13m 55s |
| Commit |
|
| Committer | Scott Cytacki |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
3
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
|
I'm going to rebase this on master because of the uncertainty of the local-storage-dev-root PR that it is current based on. |
Changes to the test: - need to comment on exemplar docs twice to make doc show up in the correct strategy sort group - deleting strategies is not supported, the test confirms the wrong behavior so we remember to fix it when we fix the behavior Other changes: - the requesting of the investigation by ordinal was wrong and was causing console warnings, fixing this also has fixed part of the issue with titles PT-188227517 - removed the firestoreTagDocumentMap, it was not actually being populated so was not really used in getTagsWithDocs. - handle the case where users comment on exemplar documents. Previously this was causing duplicate items in the sort work groups.
scytacki
force-pushed
the
188158639-renable-and-fix-cypress-test
branch
from
8dea7f8
to
e757aaa
Compare
scytacki
changed the base branch from
188211348-local-storage-dev-root
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the test:
Runtime changes:
Cypress config changes:
test:cypress:cinpm scriptcypress.dev.jsonconfigurationcypress.local.jsonso local runs of Cypress have a shorter timeout. This way you only have to way 5 seconds instead of 1 minute for Cypress to give up looking for something to exist or not exist. The default configuration is still 1 minute which will be used when Cypress is run on GitHub