Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable Cypress test and fix bugs it turned up #2405

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Reenable Cypress test and fix bugs it turned up #2405

merged 3 commits into from
Sep 17, 2024

Commits on Sep 17, 2024

  1. reenable cypress test and fix some sort work issues 

    Changes to the test:
- need to comment on exemplar docs twice to make doc show up in the correct strategy sort group
- deleting strategies is not supported, the test confirms the wrong behavior so we remember to fix it when we fix the behavior

Other changes:
- the requesting of the investigation by ordinal was wrong and was causing console warnings, fixing this also has fixed part of the issue with titles PT-188227517
- removed the firestoreTagDocumentMap, it was not actually being populated so was not really used in getTagsWithDocs.
- handle the case where users comment on exemplar documents. Previously this was causing duplicate items in the sort work groups.
    @scytacki
    scytacki committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    42d79e8 View commit details
    Browse the repository at this point in the history

  2. decrease Cypress timeout when running locally

    @scytacki
    scytacki committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    073a763 View commit details
    Browse the repository at this point in the history

  3. include fixes that Ethan found in a closed PR

    @scytacki
    scytacki committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e757aaa View commit details
    Browse the repository at this point in the history