-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test warnings #370
Fix test warnings #370
Conversation
3b6b675
to
bdc1c13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done self-reviewing. Tests should pass without emitting any warnings to the console.
If we merge #369 first, then we can check that this PR fixes the console warnings in CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabalafou Could you rebase on main? I want to check there are no errors/warnings on CI before I approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recent lockfile changes are preventing the tests from passing, I think. Try rebasing? Otherwise this looks good.
This reverts commit 546a869.
bdc1c13
to
5de21e4
Compare
@peytondmurray checks pass, but the PR needs approval before I can merge it in |
I'm not sure if there's already a GitHub issue for this, but see #357 (comment)
Description
This PR fixes things so that there are no warnings when running
yarn test
.Note: PR #357 fixed the errors, not the warnings.
Pull request checklist