Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test warnings #370

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Fix test warnings #370

merged 6 commits into from
Mar 5, 2024

Conversation

gabalafou
Copy link
Contributor

@gabalafou gabalafou commented Feb 10, 2024 •
edited
Loading

I'm not sure if there's already a GitHub issue for this, but see #357 (comment)

Description

This PR fixes things so that there are no warnings when running yarn test.

Note: PR #357 fixed the errors, not the warnings.

Pull request checklist

  • Did you test this change locally?
  • [n/a] Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@gabalafou gabalafou changed the title Fix jest warnings Fix test warnings Feb 10, 2024
@trallard trallard added area: testing ✅ Design of the test infrastructure and everything related needs: review 👀 labels Feb 12, 2024
@nkaretnikov nkaretnikov mentioned this pull request Feb 12, 2024
Closed
3 tasks
gabalafou
gabalafou commented Feb 12, 2024
View reviewed changes
Copy link
Contributor Author

@gabalafou gabalafou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done self-reviewing. Tests should pass without emitting any warnings to the console.

src/features/environments/components/EnvironmentDropdown.tsx Show resolved Hide resolved
@gabalafou
Copy link
Contributor Author

If we merge #369 first, then we can check that this PR fixes the console warnings in CI.

nkaretnikov
nkaretnikov previously requested changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@nkaretnikov nkaretnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabalafou Could you rebase on main? I want to check there are no errors/warnings on CI before I approve.

peytondmurray
peytondmurray requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recent lockfile changes are preventing the tests from passing, I think. Try rebasing? Otherwise this looks good.

src/features/environments/components/EnvironmentDropdown.tsx Show resolved Hide resolved
@gabalafou
Copy link
Contributor Author

@peytondmurray checks pass, but the PR needs approval before I can merge it in

@gabalafou gabalafou dismissed nkaretnikov’s stale review March 5, 2024 21:11

Checks pass, Peyton approved

@gabalafou gabalafou merged commit 7ff007e into conda-incubator:main Mar 5, 2024
4 checks passed
gabalafou added a commit to gabalafou/conda-store-ui that referenced this pull request Jul 9, 2024
@gabalafou
Fix test warnings (conda-incubator#370)
69e391d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peytondmurray peytondmurray peytondmurray approved these changes

@nkaretnikov nkaretnikov nkaretnikov left review comments

Assignees
No one assigned
Labels
area: testing ✅ Design of the test infrastructure and everything related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabalafou @nkaretnikov @peytondmurray @trallard