DEV - Improve bundling and release #418
Conversation
| * | ||
| * This file is part of the tree-finder library, distributed under the terms of |
There was a problem hiding this comment.
Since this was completely re-worked we do not need this heading
trallard
added
type: bug 🐛
| // To improve build times for large projects enable fork-ts-checker-webpack-plugin | ||
| // const ForkTsCheckerWebpackPlugin = require("fork-ts-checker-webpack-plugin"); | ||
| const isProd = process.env.NODE_ENV === "production"; | ||
| const ASSET_PATH = isProd ? "" : "/"; |
There was a problem hiding this comment.
This is needed so that we can bundle the UI for conda-store-server
trallard
changed the title
| 1. Create a new branch for the release `git checkout -b release-2024.9.1` | ||
| 1. Clean the branch `git clean -fxdq` | ||
| 1. Increment the version in `package.json` | ||
| 1. Build the package locally: |
There was a problem hiding this comment.
Why repeat the same info from the issue template?
There was a problem hiding this comment.
People sometimes look for the release.md file if curious vs. an issue template, so it would not hurt to keep this
There was a problem hiding this comment.
My concern is more about the repeated content, which then has to be updated in two places instead of one if these two documents are not going to get out of sync
| enforce: "pre", | ||
| exclude: /node_modules/, | ||
| }, | ||
| { test: /\.js.map$/, use: "file-loader" }, |
There was a problem hiding this comment.
Seems like this one was deleted. Was it not needed?
There was a problem hiding this comment.
This has now been deprecated so moved to module assets https://v4.webpack.js.org/loaders/file-loader/
There was a problem hiding this comment.
I'm not solid on any of this, but I thought the rules still had to stay in place, but the use: "file-loader" could be replaced with type: "asset/resource" or type: "asset". This is how you moved over the SVG rules.
I'm just pattern-matching here. I see that the SVG rules have been carried over, but not the bitmap rules, nor this .js.map rule.
There was a problem hiding this comment.
Although I'm not sure about why .js.map is needed because the source maps seemed to work in all of the different ways that I built the app after applying the code changes from this PR (not just webpack dev server mode).
There was a problem hiding this comment.
Aside from the existing docs suggestions, I'll defer to @gabalafou on webpack configuration changes. Thanks for this 🚀
|
Ahh, looks like playwright tests aren't passing - there's a Save button it seems to be waiting on. |
|
Hopefully PR #422 addresses the Playwright failure |
|
@trallard thanks for responding to all of my questions. I took this PR on three different test drives:
I clicked around. I logged in, logged out. I didn't kick off any new builds or create any new environments, but I don't see how this PR would affect that. So I doubt the Playwright failure is related, but if we want to be safe we could try merging in #422 first and then rebasing this PR. |
Fixes #408
Description
Changes in #389 broke the already brittle bundling of
conda-store+conda-store-ui.This pull request:
uiside of the bundlingwebpack.config(and the bundling overall)Pull request checklist
Additional information
Note
I did test this locally, the bundle seems fine and the app works as expected when running the Docker/out-of Docker stuff but I get this warning