Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed default values for mandatory parameters (PHP 8 fix) #226

Merged

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Jan 2, 2025

Closes #213.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.17%. Comparing base (7c811b7) to head (63f0ae1).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Jira/Api/Client/MemcacheProxyClient.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #226   +/-   ##
=========================================
  Coverage     63.17%   63.17%           
  Complexity      208      208           
=========================================
  Files            10       10           
  Lines           687      687           
=========================================
  Hits            434      434           
  Misses          253      253           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099 aik099 merged commit ecbe2c0 into console-helpers:master Jan 2, 2025
11 of 12 checks passed
@aik099 aik099 deleted the optional-before-required-params-fix branch January 2, 2025 18:44
aik099 added a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid having optional parameters before required in method signatures
1 participant