Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed default values for mandatory parameters (PHP 8 fix) #226

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Removed default values for mandatory parameters (PHP 8 fix) #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Jira/Api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@ public function createRemoteLink(
* @return array|Result|false
*/
public function api(
$method = self::REQUEST_GET,
$method,
$url,
$data = array(),
$return_as_array = false,
Expand Down
2 changes: 1 addition & 1 deletion src/Jira/Api/Client/ClientInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ interface ClientInterface
public function sendRequest(
$method,
$url,
$data = array(),
$data,
$endpoint,
AuthenticationInterface $credential,
$is_file = false,
Expand Down
2 changes: 1 addition & 1 deletion src/Jira/Api/Client/CurlClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function __construct()
public function sendRequest(
$method,
$url,
$data = array(),
$data,
$endpoint,
AuthenticationInterface $credential,
$is_file = false,
Expand Down
4 changes: 2 additions & 2 deletions src/Jira/Api/Client/MemcacheProxyClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
*
* @param string $method Request method.
* @param string $url URL.
* @param array $data Request data.
* @param array|string $data Request data.
* @param string $endpoint Endpoint.
* @param AuthenticationInterface $credential Credential.
* @param boolean $is_file This is a file upload request.
Expand All @@ -75,7 +75,7 @@
public function sendRequest(
$method,
$url,
$data = array(),
$data,

Check warning on line 78 in src/Jira/Api/Client/MemcacheProxyClient.php

View check run for this annotation

Codecov / codecov/patch

src/Jira/Api/Client/MemcacheProxyClient.php#L78 

Added line #L78 was not covered by tests
$endpoint,
AuthenticationInterface $credential,
$is_file = false,
Expand Down
2 changes: 1 addition & 1 deletion src/Jira/Api/Client/PHPClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ protected function isHttpsSupported()
public function sendRequest(
$method,
$url,
$data = array(),
$data,
$endpoint,
AuthenticationInterface $credential,
$is_file = false,
Expand Down
Loading