Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: Add explicit --format argument #639

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

cgwalters
Copy link
Collaborator

Prep for adding --format=human for example. But this is also useful for anything that explicitly wants to consume YAML today.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM but I don't see docs.

Q: Shall we remove the --json flag before 1.0?

@cgwalters
Copy link
Collaborator Author

Code LGTM but I don't see docs.

Currently the man pages are auto-generated into tarball releases; there's a currently manual cargo xtask man2markdown which also auto-reflects the manpages into markdown stored in git. (It's confusing...and tempting to go to writing man pages ...manually)

Q: Shall we remove the --json flag before 1.0?

I marked it hidden, but it's trivial to continue to support for now.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Prep for adding `--format=human` for example. But this
is also useful for anything that explicitly wants to consume
YAML today.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters enabled auto-merge June 26, 2024 14:00
@cgwalters cgwalters merged commit 5e9279d into containers:main Jun 26, 2024
15 of 19 checks passed
cgwalters added a commit to cgwalters/bootc that referenced this pull request Nov 6, 2024
proxy: Fix logic error with auth_data switch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants