install: Disable fsync() in repo when pulling && improved pull progress #655
Conversation
The goal here is to get interactive progress on pulling, as that can be slow and also I'd like to get more information there. Signed-off-by: Colin Walters <[email protected]>
This more than doubles the copy phase speed for me. We rely on a final fsync/flush of the disks when unmounting. Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
install-progress
branch
from
6453628
to
d628101
Compare
|
@henrywang Hmm, Have you see this in other PRs? I think it'd be helpful to acquire the full systemd journal here, is that easily doable? |
indicatif has nice support for multiple bars. Instead of hand-rolling a `[nn/NN]` for the overall layer count, change things so that we have: ``` Fetching layers [bar...] 8/65 ostree chunk sha256:29fc11ff03e4b3 [bar] (0 B/s) ``` Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
install-progress
branch
from
d628101
to
d8b5df2
Compare
|
Overall looks great to me. The only thing is that it appears to cut off the I'm not familiar with |
|
Yeah, I finally figured out that mutating the |
It's only by doing this that we end up calling into the code inside `attach()` that tries to ensure the terminal size matching. Otherwise we just get the default of 80 columns (and no dynamic SIGWINCH resizing). This fixes the output in containers/bootc#655 Signed-off-by: Colin Walters <[email protected]>
|
Figured it out containers/podman-bootc#55 |
Nice, I had gotten as far as: https://github.com/console-rs/console/blob/master/src/unix_term.rs#L46-L64 And determined that |
See individual patches. Motivated by #646