Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Disable fsync() in repo when pulling && improved pull progress #655

Merged
merged 3 commits into from
Jul 3, 2024

Commits on Jun 29, 2024

  1. install: Use separate pull stage for progress output

    The goal here is to get interactive progress on pulling,
    as that can be slow and also I'd like to get more information there.
    
    Signed-off-by: Colin Walters <[email protected]>
    cgwalters committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    8b30128 View commit details
    Browse the repository at this point in the history
  2. install: Disable fsync() in repo when pulling

    This more than doubles the copy phase speed for me. We
    rely on a final fsync/flush of the disks when unmounting.
    
    Signed-off-by: Colin Walters <[email protected]>
    cgwalters committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    6c81a40 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. pull: Improved progress output

    indicatif has nice support for multiple bars. Instead
    of hand-rolling a `[nn/NN]` for the overall layer count,
    change things so that we have:
    
    ```
    Fetching layers [bar...] 8/65
     ostree chunk sha256:29fc11ff03e4b3 [bar] (0 B/s)
    ```
    
    Signed-off-by: Colin Walters <[email protected]>
    cgwalters committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    d8b5df2 View commit details
    Browse the repository at this point in the history