Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lints stricter, apply crate wide #795

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

cgwalters
Copy link
Collaborator

Add dead_code = "deny" to our default lints; we had a compiler warning for this in main.

Fix the warning by moving the human readable test code into #[cfg(test)].

While we're here, move the other lib.rs lints into the crate; enforcing docs for everything at first I thought might be heavy handed but actually is fine as it only applies to things that are pub, of which we don't actually have that much so it mainly forced me to add some stub docs for the modules, which is probably a good idea.

Add `dead_code = "deny"` to our default lints; we had
a compiler warning for this in main.

Fix the warning by moving the human readable test code into
`#[cfg(test)]`.

While we're here, move the other lib.rs lints into the crate;
enforcing docs for *everything* at first I thought might be heavy
handed but actually is fine as it only applies to things that
are `pub`, of which we don't actually have that much so it
mainly forced me to add some stub docs for the modules, which
is probably a good idea.

Signed-off-by: Colin Walters <[email protected]>
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgwalters cgwalters merged commit d5a623a into containers:main Sep 18, 2024
28 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants