Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lints stricter, apply crate wide #795

Merged
merged 1 commit into from
Sep 18, 2024

Commits on Sep 18, 2024

  1. Make lints stricter, apply crate wide

    Add `dead_code = "deny"` to our default lints; we had
    a compiler warning for this in main.
    
    Fix the warning by moving the human readable test code into
    `#[cfg(test)]`.
    
    While we're here, move the other lib.rs lints into the crate;
    enforcing docs for *everything* at first I thought might be heavy
    handed but actually is fine as it only applies to things that
    are `pub`, of which we don't actually have that much so it
    mainly forced me to add some stub docs for the modules, which
    is probably a good idea.
    
    Signed-off-by: Colin Walters <[email protected]>
    cgwalters committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    97692bd View commit details
    Browse the repository at this point in the history