libcrun: handle SIGWINCH by resizing terminal_fd #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@terinjokes thanks! Can you please fix formatting issues? |
|
Ah, sorry. I'm used to my editor formatting on save. 😅 One moment. |
When receiving the WINCH signal, crun was using the default signal behavior of passing it through to the child process. A child that cared about the terminal size would then call the TIOCGWINSZ ioctl, but find the size had not changed. This is due to crun not copying the terminal size for its stdin to the child's pty. This changeset handles the WINCH signal by getting crun's terminal size, and setting the child's pty to match. The WINCH signal is not passed through, as the kernel will send it as part of handling the TIOCSWINSZ ioctl. Signed-off-by: Terin Stock <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving the WINCH signal, crun was using the default signal behavior of passing it through to the child process. A child that cared about the terminal size would then call the TIOCGWINSZ ioctl, but find the size had not changed. This is due to crun not copying the terminal size for its stdin to the child's pty.
This changeset handles the WINCH signal by getting crun's terminal size, and setting the child's pty to match. The WINCH signal is not passed through, as the kernel will send it as part of handling the TIOCSWINSZ ioctl.