Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcrun: handle SIGWINCH by resizing terminal_fd #1262

Merged
merged 1 commit into from
Aug 8, 2023
Merged

libcrun: handle SIGWINCH by resizing terminal_fd #1262

merged 1 commit into from
Aug 8, 2023

Commits on Aug 7, 2023

  1. libcrun: handle SIGWINCH by resizing terminal_fd 

    When receiving the WINCH signal, crun was using the default signal
behavior of passing it through to the child process. A child that cared
about the terminal size would then call the TIOCGWINSZ ioctl, but find
the size had not changed. This is due to crun not copying the terminal
size for its stdin to the child's pty.

This changeset handles the WINCH signal by getting crun's terminal size,
and setting the child's pty to match. The WINCH signal is not passed
through, as the kernel will send it as part of handling the TIOCSWINSZ
ioctl.

Signed-off-by: Terin Stock <[email protected]>
    @terinjokes
    terinjokes committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    907d032 View commit details
    Browse the repository at this point in the history