Add --log-stderr option
#1542
Merged
Add --log-stderr option
#1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
podman system tests failed. @containers/packit-build please check. |
This option was inherited before, but now we can set it explicitly to allow/disallow logging to stderr when selecting a certain log driver. For example on exec, we would need to log log anything to stdio even when the debug logs are enabled. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
log-stderr
branch
from
54d181f
to
b98e0dd
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
podman system tests failed. @containers/packit-build please check. |
|
/approve |
|
I had to revert this patch as it causes the containerd tests to fail: #1545 runc doesn't seem to have the same option. Should we make it accept an argument so that we can turn it off and leave the default as it is now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was inherited before, but now we can set it explicitly to allow/disallow logging to stderr when selecting a certain log driver.
For example on exec, we would need to log anything to stdio even when the debug logs are enabled.
Refers to #1525