Only log to stderr if --log is not provided
#1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@giuseppe let me know if you still prefer the |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
podman system tests failed. @containers/packit-build please check. |
saschagrunert
force-pushed
the
stderr
branch
from
9d3551f
to
a5e3f04
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
podman system tests failed. @containers/packit-build please check. |
saschagrunert
changed the title
--log is not provided--log is not provided
In any other case we log to the dedicated log driver for consistency reason. This avoids having another option like `--log-stderr`. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
stderr
branch
from
a5e3f04
to
a295e70
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
saschagrunert
changed the title
--log is not provided--log is not provided
|
@giuseppe PTAL, we still have to report errors to the CLI to make containerd integration tests happy. |
|
podman system tests failed. @containers/packit-build please check. |
|
thanks for working on this alternative. I am fine with it (and containerd too 😄 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In any other case we log to the dedicated log driver for consistency reason. This avoids having another option like
--log-stderr.Needs #1545
Alternative to #1542