Fix additional_gids_size on process_user_dup
#1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size needs to be set as well otherwise we may break `additional_gids`. Found in critest, like: https://github.com/cri-o/cri-o/actions/runs/10680190170/job/29601173374 ``` Summarizing 3 Failures: [FAIL] [k8s.io] Security Context SupplementalGroupsPolicy when SupplementalGroupsPolicy=Strict [It] even if the container's primary UID belongs to some groups in the image, runtime should not add SupplementalGroups to them sigs.k8s.io/cri-tools/pkg/validate/security_context_linux.go:737 [FAIL] [k8s.io] Security Context bucket [It] runtime should support SupplementalGroups sigs.k8s.io/cri-tools/pkg/validate/security_context_linux.go:309 [FAIL] [k8s.io] Security Context SupplementalGroupsPolicy when SupplementalGroupsPolicy=Merge (Default) [It] if the container's primary UID belongs to some groups in the image, runtime should add SupplementalGroups to them sigs.k8s.io/cri-tools/pkg/validate/security_context_linux.go:669 ``` Signed-off-by: Sascha Grunert <[email protected]>
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
podman system tests failed. @containers/packit-build please check. |
|
Nice catch! /approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size needs to be set as well otherwise we may break
additional_gids.Found in critest, like: https://github.com/cri-o/cri-o/actions/runs/10680190170/job/29601173374
Follow-up on #1538