Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix additional_gids_size on process_user_dup #1543

Merged
merged 1 commit into from
Sep 3, 2024

Commits on Sep 3, 2024

  1. Fix additional_gids_size on process_user_dup

    The size needs to be set as well otherwise we may break `additional_gids`.
    
    Found in critest, like: https://github.com/cri-o/cri-o/actions/runs/10680190170/job/29601173374
    
    ```
    Summarizing 3 Failures:
      [FAIL] [k8s.io] Security Context SupplementalGroupsPolicy when SupplementalGroupsPolicy=Strict [It] even if the container's primary UID belongs to some groups in the image, runtime should not add SupplementalGroups to them
      sigs.k8s.io/cri-tools/pkg/validate/security_context_linux.go:737
      [FAIL] [k8s.io] Security Context bucket [It] runtime should support SupplementalGroups
      sigs.k8s.io/cri-tools/pkg/validate/security_context_linux.go:309
      [FAIL] [k8s.io] Security Context SupplementalGroupsPolicy when SupplementalGroupsPolicy=Merge (Default) [It] if the container's primary UID belongs to some groups in the image, runtime should add SupplementalGroups to them
      sigs.k8s.io/cri-tools/pkg/validate/security_context_linux.go:669
    ```
    
    Signed-off-by: Sascha Grunert <[email protected]>
    saschagrunert committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    a32d433 View commit details
    Browse the repository at this point in the history