[release-0.3/#222] pkg/apis, helm: update balloons config/CRD. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `omitempty` JSON tags for balloons config `PreferCloseToDevices` and `IdleCpuClass`, so they properly imply optionality in the corresponding CRD fields. Tag `PreferFarFromDevices` is considered unstable/untested and should not be used. Hence, tag it as `"-"` to prevent unmarshalling it from a CRD to the actual configuration. Signed-off-by: Krisztian Litkey <[email protected]>
It looks like the latest balloons configuration additions have been committed then merged without updating the configuration, CRDs and clientsets. Let's fix it. Signed-off-by: Krisztian Litkey <[email protected]>
Add target for verifying that all generated artifacts are up to date in the repo. Hook it in to the top-level verify target, so it will be run as part of our github CI workflows. Signed-off-by: Krisztian Litkey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #222 to the 0.3 release branch.