Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.3/#222] pkg/apis, helm: update balloons config/CRD. #230

Merged
merged 3 commits into from
Jan 12, 2024
Merged

[release-0.3/#222] pkg/apis, helm: update balloons config/CRD. #230

merged 3 commits into from
Jan 12, 2024

Commits on Jan 12, 2024

  1. pkg/apis/config: fix balloons config tags. 

    Fix `omitempty` JSON tags for balloons config `PreferCloseToDevices`
and `IdleCpuClass`, so they properly imply optionality in the
corresponding CRD fields.

Tag `PreferFarFromDevices` is considered unstable/untested and should
not be used. Hence, tag it as `"-"` to prevent unmarshalling it from
a CRD to the actual configuration.

Signed-off-by: Krisztian Litkey <[email protected]>
    @klihub
    klihub committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    bc78491 View commit details
    Browse the repository at this point in the history

  2. pkg/apis, helm: update balloons config/CRD. 

    It looks like the latest balloons configuration additions have
been committed then merged without updating the configuration,
CRDs and clientsets. Let's fix it.

Signed-off-by: Krisztian Litkey <[email protected]>
    @klihub
    klihub committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    4bc8142 View commit details
    Browse the repository at this point in the history

  3. Makefile: add 'verify-generate' target. 

    Add target for verifying that all generated artifacts are up to
date in the repo. Hook it in to the top-level verify target, so
it will be run as part of our github CI workflows.

Signed-off-by: Krisztian Litkey <[email protected]>
    @klihub
    klihub committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    c0fb898 View commit details
    Browse the repository at this point in the history