Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exit code error in build command on Node 20+ #599

Closed
wants to merge 1 commit into from

Conversation

jrolfs
Copy link

@jrolfs jrolfs commented Nov 15, 2023

This should close #495 pending @schickling's take on whether this is the correct remediation.

Although I'm very keen to dig more into Effect, I'm still very much a noob in that department. This fix assumes that since everything in the command is wrapped in an Effect that no additional error handling is necessary to handle actual runtime errors, but I haven't tested out that assumption yet.

Copy link

changeset-bot bot commented Nov 15, 2023

🦋 Changeset detected

Latest commit: 741d455

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "examples-*" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link

stale bot commented Dec 5, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale label Dec 5, 2023
@kachkaev
Copy link

kachkaev commented Dec 5, 2023

not stale

@stale stale bot removed the meta: stale label Dec 5, 2023
Copy link

stale bot commented Dec 26, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale label Dec 26, 2023
@notunderctrl
Copy link

not stale

@stale stale bot removed the meta: stale label Dec 26, 2023
Copy link

stale bot commented Jan 16, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale label Jan 16, 2024
@kachkaev
Copy link

not stale 🙏

@stale stale bot removed the meta: stale label Jan 16, 2024
Copy link

stale bot commented Feb 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added meta: stale and removed meta: stale labels Feb 5, 2024
@jrolfs
Copy link
Author

jrolfs commented Feb 5, 2024

not... stale... 🙏🏻

@trevoro
Copy link

trevoro commented Feb 15, 2024

This is the funniest and most tragic pull request comment thread I've seen in years. @jrolfs thanks for doing this dude.

Copy link

stale bot commented Mar 7, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale label Mar 7, 2024
@notunderctrl
Copy link

notunderctrl commented Mar 7, 2024

not stale.

Copy link

stale bot commented Mar 30, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale label Mar 30, 2024
@notunderctrl
Copy link

notunderctrl commented Mar 30, 2024

not stale.

@stale stale bot removed the meta: stale label Mar 31, 2024
Copy link

stale bot commented Apr 23, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale label Apr 23, 2024
@kachkaev
Copy link

not stale

@stale stale bot removed the meta: stale label Apr 23, 2024
@timlrx timlrx mentioned this pull request Apr 23, 2024
@timlrx
Copy link

timlrx commented Apr 23, 2024

@jrolfs I merged your fix in timlrx/contentlayer2#8 - published as contentlayer2 v0.4.5. Tested it out verified that yarn contentlayer2 build no longer throws the error message in node 20.

Copy link

stale bot commented May 13, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale label May 13, 2024
@stale stale bot closed this May 21, 2024
@kachkaev
Copy link

🇫

@jrolfs
Copy link
Author

jrolfs commented May 21, 2024

@timlrx thanks and thanks for getting a fork off the ground! I was considering doing it myself but will switch our stuff over to yours (currently running a patched version).

@jrolfs
Copy link
Author

jrolfs commented May 27, 2024

For anyone following this, I switched to the fork, and it's working great and includes this fix. I wrote some docs on how to switch over here.

@justice-sh
Copy link

Thank you very much guys. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants