Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cxl-ui): cxl-section - remove top margin #369

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

freudFlintstone
Copy link

Copy link

github-actions bot commented Dec 8, 2023

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 68.76 KB (-0.07% 🔽)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 28.13 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 136.06 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 246.01 KB (-0.02% 🔽)

Copy link

@lkraav lkraav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would've thought

margin-top: var(--lumo-space-xl);
just this needs to go away?

@lkraav
Copy link

lkraav commented Dec 11, 2023

I would've thought

margin-top: var(--lumo-space-xl);

just this needs to go away?

I see a 👍 emoji but no updates to PR?

@freudFlintstone
Copy link
Author

I would've thought

margin-top: var(--lumo-space-xl);

just this needs to go away?

I see a 👍 emoji but no updates to PR?

@lkraav, done. Got distracted and forgot.

@pawelkmpt pawelkmpt merged commit 9b77640 into master Dec 12, 2023
5 checks passed
@pawelkmpt pawelkmpt deleted the raphael/fix/facelift/hero-margins branch December 12, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants