Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cxl-ui): cxl-section - remove top margin #369

Merged
merged 1 commit into from
Dec 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/cxl-ui/scss/cxl-section.scss
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@

:host(#view-hero),
:host([theme~="cxl-hero"]) {
margin-top: var(--lumo-space-xl);
background-color: transparent !important; /* stylelint-disable-line declaration-no-important */
}

Expand Down
5 changes: 1 addition & 4 deletions packages/cxl-ui/scss/global/cxl-section.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
@use "~@conversionxl/cxl-lumo-styles/scss/mq";

cxl-section#view-hero, cxl-section[theme~="cxl-hero"] {

.column-1 {
@media #{mq.$medium} {
max-width: 45%;
Expand All @@ -19,10 +20,6 @@ cxl-section#view-hero, cxl-section[theme~="cxl-hero"] {
}

&.wide-background-light-blue {
#view-hero .cxl-hero-titles {
lkraav marked this conversation as resolved.
Show resolved Hide resolved
bottom: 0;
transform: translateY(50%);
}

.column-2 {
* {
Expand Down
Loading