Styles

[anoblet]

https://app.clickup.com/t/86b1dy579

[github-actions]

size-limit report 📦

Path	Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js	44.75 KB (-0.01% 🔽)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js	11.89 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js	29.23 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js	138.23 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-institute.js, packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js	277.57 KB (-0.01% 🔽)

[pawelkmpt]

Please also commit "Increase font size" styles which are currently in institute customizer

[pawelkmpt]

why properties-order rule is bad and you removed it?

[anoblet]

It's too much of a headache remembering the CSS Spec. I prefer alphabetical.

[pawelkmpt]

Isn't it corrected automatically by linter?

[anoblet]

It's not :/ I don't mind using the default rules, though we could also use this? https://github.com/hudochenkov/stylelint-order/tree/master/rules/properties-alphabetical-order

[pawelkmpt]

Please also commit "Increase font size" styles which are currently in institute customizer

@anoblet follow up

[anoblet]

Will get it done by EOD.

[anoblet]

We have these styles in customizer, which conflict with what's in this PR:

details {
  margin: var(--lumo-space-m) 0;
}

details summary {
  font-weight: 900;
  margin-bottom: var(--lumo-space-s);
}

I believe that we should remove these from customizer and go with what's in this PR.

[pawelkmpt]

We have these styles in customizer, which conflict with what's in this PR:

details {
  margin: var(--lumo-space-m) 0;
}

details summary {
  font-weight: 900;
  margin-bottom: var(--lumo-space-s);
}

I believe that we should remove these from customizer and go with what's in this PR.

Where do you see the conflict?
Native details are used for FAQ, e.g. https://cxl.com/institute/programs/conversion-optimization/
and what you pushed here is for vaadin-details https://cxl.com/institute/lesson/where-and-what-to-test-to-maximize-roi/