Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles #434

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Styles #434

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd6d19a
feat(cxl-ui): cxl-certificate-header update description font size
anoblet Oct 1, 2024
23b48a9
feat(cxl-ui): cxl-course-card update font size
anoblet Oct 1, 2024
7918433
feat(cxl-lumo-styles): update vaadin details styles
anoblet Oct 1, 2024
7691dc4
feat(cxl-lumo-styles): increase the font size of common elements
anoblet Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/cxl-ui/scss/cxl-course-card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
/* stylelint-disable value-no-vendor-prefix, property-no-vendor-prefix -- some of these are necessary for line-clamp implementation */
/* stylelint-disable declaration-no-important */
/* stylelint-disable declaration-no-important, order/properties-order */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why properties-order rule is bad and you removed it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's too much of a headache remembering the CSS Spec. I prefer alphabetical.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it corrected automatically by linter?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not :/ I don't mind using the default rules, though we could also use this? https://github.com/hudochenkov/stylelint-order/tree/master/rules/properties-alphabetical-order


@use "~@conversionxl/cxl-ui/scss/mixins";
@use "~@conversionxl/cxl-lumo-styles/scss/typography";

:host {
font-size: var(--lumo-font-size-m);
height: 280px;
}

Expand Down