Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements to object store #52

Open
wants to merge 6 commits into
base: object-store-0.10.2
Choose a base branch
from
Open

Small improvements to object store #52

wants to merge 6 commits into from

Conversation

fsdvh
Copy link
Collaborator

@fsdvh fsdvh commented Sep 26, 2024 •
edited
Loading

Uploading last part after all intermediate parts are done

@fsdvh fsdvh changed the base branch from master to object-store-0.10.2 September 26, 2024 11:34
@fsdvh fsdvh changed the title Object store 0.10.2 cx1 Small improvements to object store Sep 26, 2024
@fsdvh fsdvh mentioned this pull request Oct 22, 2024
Open
tustvold
tustvold suggested changes Oct 22, 2024
View reviewed changes
Copy link

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a reproducer of the issue this is trying to fix, as it stands this adds latency by serializing finish, despite this not being required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkharderdev thinkharderdev thinkharderdev approved these changes

@tustvold tustvold tustvold requested changes

Assignees
No one assigned
Labels
object-store
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fsdvh @thinkharderdev @tustvold