Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements to object store #52

Open
wants to merge 7 commits into
base: object-store-0.10.2
Choose a base branch
from
+113 −136
Open

Small improvements to object store #52

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8fb7cb2
small improvements
fsdvh Sep 26, 2024
3c49dd6
empty
fsdvh Sep 26, 2024
d174679
atomic value part_idx
fsdvh Sep 27, 2024
60db4c6
revert some changes
fsdvh Sep 27, 2024
09bcd4a
update
fsdvh Sep 27, 2024
ef03546
change finish method
fsdvh Oct 21, 2024
545fd20
Add checksum (#61)
avantgardnerio Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions object_store/src/upload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,13 +220,13 @@ impl WriteMultipart {

/// Flush final chunk, and await completion of all in-flight requests
pub async fn finish(mut self) -> Result<PutResult> {
self.wait_for_capacity(0).await?;

if !self.buffer.is_empty() {
let part = std::mem::take(&mut self.buffer);
self.put_part(part.into())
self.upload.put_part(part.into()).await?;
}

self.wait_for_capacity(0).await?;

match self.upload.complete().await {
Err(e) => {
self.tasks.shutdown().await;
Expand Down
Loading