build: Drop down to 50 layers for chunked images #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xref openshift/os#808 |
|
/override ci/prow/rhcos |
|
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cgwalters
force-pushed
the
encap-drop-maxlayers
branch
from
2c3a15a
to
cb21434
Compare
jlebon
previously approved these changes
Jun 9, 2022
jlebon
reviewed
Jun 9, 2022
src/cmdlib.sh
Outdated
| # for (older?) versions of podman AKA containers/storage (or maybe) | ||
| # a kernel limitation? For example | ||
| # `cannot mount layer, mount label "" too large 4168 > page size 4096` | ||
| MAX_OSTREECONTAINER_LAYERS=50 |
There was a problem hiding this comment.
In src/cmdlib.sh line 43:
MAX_OSTREECONTAINER_LAYERS=50
^------------------------^ SC2034: MAX_OSTREECONTAINER_LAYERS appears unused. Verify use (or export if used externally).
It seems that (at least older?) containers/storage barfs on this, so let's drop down a good bit. (We could also change the ostree upstream default, but...mmm, perhaps later)
cgwalters
force-pushed
the
encap-drop-maxlayers
branch
from
cb21434
to
c973251
Compare
jlebon
approved these changes
Jun 9, 2022
|
/override ci/prow/rhcos |
|
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that (at least older?) containers/storage barfs on this, so let's drop
down a good bit.
(We could also change the ostree upstream default, but...mmm, perhaps
later)