Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image: Switch to oci-chunked format #808

Merged

Conversation

cgwalters
Copy link
Member

Now that we have rpm-ostree v2022.2 in the bootimage, we should
be able to switch to the chunked image format.

This matches coreos/fedora-coreos-config#1698

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2022
@travier
Copy link
Member

travier commented Jun 1, 2022

Should we hold on this one until master is 4.12?

@travier
Copy link
Member

travier commented Jun 1, 2022

Hum, looks like this is already the case: https://github.com/openshift/os/tree/release-4.11

@cgwalters
Copy link
Member Author

Should we hold on this one until master is 4.12?

Yeah, I guess we might as well.

@cgwalters cgwalters force-pushed the ostree-format-split branch 2 times, most recently from 70254e0 to 8b359ed Compare June 8, 2022 21:41
@cgwalters
Copy link
Member Author

error: build error: error committing container for step {Env:[BUILD_LOGLEVEL=0 OPENSHIFT_BUILD_NAME=machine-os-oci-content OPENSHIFT_BUILD_NAMESPACE=ci-op-ithpf5wd PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin] Command:label Args:[io.openshift.build.name machine-os-oci-content io.openshift.build.namespace ci-op-ithpf5wd io.openshift.build.commit.author  io.openshift.build.commit.date  io.openshift.build.commit.id  io.openshift.build.commit.message  io.openshift.build.commit.ref  io.openshift.build.name  io.openshift.build.namespace  io.openshift.build.source-context-dir  io.openshift.build.source-location  vcs-ref  vcs-type  vcs-url ] Flags:[] Attrs:map[] Message:LABEL "io.openshift.build.name" "machine-os-oci-content" "io.openshift.build.namespace" "ci-op-ithpf5wd" "io.openshift.build.commit.author" "" "io.openshift.build.commit.date" "" "io.openshift.build.commit.id" "" "io.openshift.build.commit.message" "" "io.openshift.build.commit.ref" "" "io.openshift.build.name" "" "io.openshift.build.namespace" "" "io.openshift.build.source-context-dir" "" "io.openshift.build.source-location" "" "vcs-ref" "" "vcs-type" "" "vcs-url" "" Original:LABEL "io.openshift.build.name"="machine-os-oci-content" "io.openshift.build.namespace"="ci-op-ithpf5wd" "io.openshift.build.commit.author"="" "io.openshift.build.commit.date"="" "io.openshift.build.commit.id"="" "io.openshift.build.commit.message"="" "io.openshift.build.commit.ref"="" "io.openshift.build.name"="" "io.openshift.build.namespace"="" "io.openshift.build.source-context-dir"="" "io.openshift.build.source-location"="" "vcs-ref"="" "vcs-type"="" "vcs-url"=""}: error copying layers and metadata for container "2195c35d8189e1727e77673dd23bdf130685d7039b29eeab6d4db3d6845bc8c9": initializing source containers-storage:latest-working-container: error creating new image source "containers-storage:latest-working-container": error extracting layer "de4146265712a44c5438a282204ab7fe821bcb03f5206abbf357540b170949bd": cannot mount layer, mount label "" too large 4168 > page size 4096

😢

This is ostreedev/ostree-rs-ext#69 (comment)

  • rpm-ostree container-encapsulate clearly needs to make the number of layers configurable
  • We're really close to the limit...would it work if we just cut down one layer? Will test
  • Probably worth seeing if there's a way we can optimize the mount layer option handling; must it really be a single page? What if overlayfs supported parsing data from...a sealed memfd or something? Or just parsed a file on disk, since it already is reading from the filesystem

@cgwalters
Copy link
Member Author

@cgwalters cgwalters marked this pull request as draft June 9, 2022 20:57
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 9, 2022
@cgwalters
Copy link
Member Author

OK this also blocks on https://bugzilla.redhat.com/show_bug.cgi?id=2095528 at least.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

@cgwalters: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-in-cluster 8b359ed link true /test test-in-cluster
ci/prow/validate-built-image 8b359ed link true /test validate-built-image
ci/prow/build-test-qemu-kola-all 8b359ed link true /test build-test-qemu-kola-all

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

We now have a version of rpm-ostree in the 4.12 bootimage which
is able to pull this.

This matches coreos/fedora-coreos-config#1698
@cgwalters cgwalters marked this pull request as ready for review August 16, 2022 15:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2022
@cgwalters
Copy link
Member Author

OK rebased 🏄 - I'd like to try landing this again!

@jlebon
Copy link
Member

jlebon commented Aug 17, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d4ffac2 into openshift:master Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants