kola: return 77 on warning and use different colors to highlight tests results #3551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nikita-dubrovskii
commented
Aug 1, 2023
nikita-dubrovskii
commented
nikita-dubrovskii
force-pushed
the
kola_warn
branch
from
44ca97a
to
7ca5410
Compare
dustymabe
reviewed
Aug 1, 2023
nikita-dubrovskii
force-pushed
the
kola_warn
branch
from
7ca5410
to
57a0198
Compare
dustymabe
reviewed
Aug 4, 2023
nikita-dubrovskii
force-pushed
the
kola_warn
branch
from
57a0198
to
9750f17
Compare
Let's get the exit code to the top level when a non-zero exit code is returned. This allows someone to take different behavior based on the exit code.
This will allow callers to behave differently based on the exitcode.
Co-authored-by: Dusty Mabe <[email protected]>
… of it was dropped in pipeline
nikita-dubrovskii
force-pushed
the
kola_warn
branch
from
9750f17
to
406f359
Compare
dustymabe
added a commit
to dustymabe/coreos-ci-lib
that referenced
this pull request
Aug 22, 2023
This commit refactors the arguments and error handling for `kola` into a runKola function to make it easier to manage. Most calls in this file use mostly the same arguments, so this is a nice cleanup. This commit also adds the `--on-warn-failure-exit-77` option [1] and adds handling to mark a test as `warn()` if that happens versus the typical `error()`. [1] coreos/coreos-assembler#3551
|
/cherry-pick rhcos-4.14 |
|
@dustymabe: new pull request created: #3578 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dustymabe
added a commit
to dustymabe/coreos-ci-lib
that referenced
this pull request
Aug 23, 2023
This commit refactors the arguments and error handling for `kola` into a runKola closure to make it easier to manage. Most calls in this file use mostly the same arguments, so this is a nice cleanup. This commit also adds the `--on-warn-failure-exit-77` option [1] and adds handling to mark a test as `warn()` if that happens versus the typical `error()`. [1] coreos/coreos-assembler#3551
dustymabe
added a commit
to coreos/coreos-ci-lib
that referenced
this pull request
Aug 23, 2023
This commit refactors the arguments and error handling for `kola` into a runKola closure to make it easier to manage. Most calls in this file use mostly the same arguments, so this is a nice cleanup. This commit also adds the `--on-warn-failure-exit-77` option [1] and adds handling to mark a test as `warn()` if that happens versus the typical `error()`. [1] coreos/coreos-assembler#3551
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.