Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin bootc to a git tag #4584

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Pin bootc to a git tag #4584

merged 1 commit into from
Sep 11, 2023

Conversation

cgwalters
Copy link
Member

We had a problem in the previous release with having bootc float on a git commit because it ends up meaning "whatever happens to be on the developer's machine" when cutting a release, which is not OK from a reproducibility PoV.

Dependabot I think can help us update this.

Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cgwalters
Copy link
Member Author

[2023-09-07T16:14:08.822Z] 2023-09-07T16:14:05Z cli: failed to establish qmp connection: dial unix /var/tmp/mantle-qemu1272236628/qmp-1694103215602187927.sock: connect: connection refused

Right, another race

@cgwalters
Copy link
Member Author

Oh wait that's not a race:

[2023-09-07T17:30:55.251Z] [2023-09-07T17:30:52Z ERROR virtiofsd] can't apply the child capabilities: failed to sync capabilities with the kernel

@cgwalters
Copy link
Member Author

Oh I see, I think what's going on is in our CI in Jenkins we override things to run as uid 0, which triggers this code:

https://gitlab.com/virtio-fs/virtiofsd/-/blob/97ea7908fe7f9bc59916671a771bdcfaf4044b45/src/main.rs#L1048

So...fun. It'd be good to drop the runasuser: 0 here...but we should also make cosa robust against this.

We had a problem in the previous release with having bootc
float on a git commit because it ends up meaning "whatever happens
to be on the developer's machine" when cutting a release, which
is not OK from a reproducibility PoV.

Dependabot I think can help us update this.
@jmarrero jmarrero merged commit 6f482f7 into coreos:main Sep 11, 2023
13 checks passed
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment)
So I can verify the fix works here.
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment)
So I can verify the fix works here.
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment)
So I can verify the fix works here.
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment)
So I can verify the fix works here.
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment)
So I can verify the fix works here.
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment)
So I can verify the fix works here.
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment)
So I can verify the fix works here.
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment)
So I can verify the fix works here.
cgwalters added a commit to cgwalters/coreos-assembler that referenced this pull request Sep 18, 2023
I want to reproduce the failure from coreos/rpm-ostree#4584 (comment)
So I can verify the fix works here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants