Fix dw2pdf multipage struct output #574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the dw2pdf plugin is used to export multiple pages in a single document, all the pages are rendered in a single instance of syntax_plugin_struct_output. We want to allow this usecase and only skip repeated calls for non-dw2pdf renderings. Signed-off-by: Frieder Schrempf <[email protected]>
fschrempf
force-pushed
the
fix-dw2pdf-multipage-struct-output
branch
from
3ab6a5f
to
05e773d
Compare
|
The whole mechanism of automatically outputting struct data on pages is somewhat fragile and depending on many variables, thus I'd be hesitant to just merge this. It should at least be accompanied by unit tests, not only for the functionality here but also for all scenarios in which output is automatically added or should not be added (like in includes, sidebars, etc). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the dw2pdf plugin is used to export multiple pages in a single document, all the pages are rendered in a single instance
of syntax_plugin_struct_output. We want to allow this usecase and only skip repeated calls for non-dw2pdf renderings.
In conjunction with splitbrain/dokuwiki-plugin-dw2pdf#435 this fixes the struct data output in multi-page PDFs.